Skip to content

[Az.ServiceFabric] Added parameter AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster #28349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 22, 2025
Merged

[Az.ServiceFabric] Added parameter AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster #28349

merged 8 commits into from
Aug 22, 2025

Conversation

iliu816
Copy link
Member

@iliu816 iliu816 commented Aug 8, 2025 •
edited
Loading

Description

Added parameter AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster

Based on instructions at https://eng.ms/docs/products/azure-service-fabric/how-to/publiccacluster/managed-tls-solution

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings August 8, 2025 00:17
@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot
Copilot AI reviewed Aug 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the AutoGeneratedDomainNameLabelScope parameter to enable migration to public CA cluster certificates in Service Fabric managed clusters. The changes also include alphabetical reordering of constructor parameters for consistency.

Key changes:

  • Added AutoGeneratedDomainNameLabelScope parameter to New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster cmdlets
  • Updated constructor parameter ordering to alphabetical in both PSManagedCluster and PSManagedNodeType models
  • Updated help documentation to include the new parameter

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
NewAzServiceFabricManagedCluster.cs Added AutoGeneratedDomainNameLabelScope parameter and implementation
SetAzServiceFabricManagedCluster.cs Added AutoGeneratedDomainNameLabelScope parameter and update logic
PSManagedCluster.cs Reordered constructor parameters alphabetically and added new property
PSManagedNodeType.cs Reordered constructor parameters alphabetically
New-AzServiceFabricManagedCluster.md Updated help documentation with new parameter
Set-AzServiceFabricManagedCluster.md Updated help documentation with new parameter
ChangeLog.md Added changelog entry for the new feature

@iliu816 iliu816 changed the title [Az.Service] Fixed Set-AzServiceFabricManagedClusterApplication to correctly overwrite existing application upgrade policy when -RecreateApplication parameter is specified and no other upgrade policy parameters are bound [Az.Service] dded parameter AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster Aug 8, 2025
@iliu816 iliu816 changed the title [Az.Service] dded parameter AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster [Az.Service] Added parameter AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster Aug 8, 2025
@iliu816 iliu816 changed the title [Az.Service] Added parameter AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster [Az.ServiceFabric] Added parameter AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster Aug 8, 2025
@NoriZC
Copy link
Contributor

NoriZC commented Aug 13, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@NoriZC NoriZC self-assigned this Aug 13, 2025
@NoriZC
Copy link
Contributor

NoriZC commented Aug 14, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@NoriZC
Copy link
Contributor

NoriZC commented Aug 19, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@iliu816
Copy link
Member Author

iliu816 commented Aug 19, 2025

@NoriZC Hi, I'm seeing the security check fail for secrets in the Compute module. Am I expected to take any action on that since the check is failing for this PR?

@NoriZC
Copy link
Contributor

NoriZC commented Aug 20, 2025 •
edited
Loading

@NoriZC Hi, I'm seeing the security check fail for secrets in the Compute module. Am I expected to take any action on that since the check is failing for this PR?

Please help fix following potential secret leakage:

[Error] 1. Credential Scanner Error CSCAN-AZURE0060 - File: SecurityTmp/src/Compute/Compute/help/Set-AzVMRunCommand.md:SecurityTmp/src/Compute/Compute/help/Set-AzVMRunCommand.md. Line: 108. Column 323.
Signature: 414f***
Tool: Credential Scanner: Rule: CSCAN-AZURE0060 (Azure Storage Account Shared Access Signature). https://aka.ms/CredScanDocs
A potential secret was detected. Validate file contains secrets, remove, rotate credential, and use approved store. For additional information on secret remediation see the remediation section at https://aka.ms/CredScanDocs
[Error] 2. Credential Scanner Error CSCAN-AZURE0060 - File: SecurityTmp/src/Compute/Compute/help/Set-AzVmssVMRunCommand.md:SecurityTmp/src/Compute/Compute/help/Set-AzVmssVMRunCommand.md. Line: 109. Column 350.
Signature: ec93***
Tool: Credential Scanner: Rule: CSCAN-AZURE0060 (Azure Storage Account Shared Access Signature). https://aka.ms/CredScanDocs
A potential secret was detected. Validate file contains secrets, remove, rotate credential, and use approved store. For additional information on secret remediation see the remediation section at https://aka.ms/CredScanDocs
Active results: 2

@NoriZC
Copy link
Contributor

NoriZC commented Aug 20, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@NoriZC
Copy link
Contributor

NoriZC commented Aug 22, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@NoriZC NoriZC enabled auto-merge (squash) August 22, 2025 05:39
@NoriZC NoriZC merged commit 81dd4dc into Azure:main Aug 22, 2025
13 checks passed
@iliu816 iliu816 deleted the user/iliu/publicCA branch August 25, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@NoriZC NoriZC NoriZC approved these changes

@wyunchi-ms wyunchi-ms Awaiting requested review from wyunchi-ms

@dolauli dolauli Awaiting requested review from dolauli

@isra-fel isra-fel Awaiting requested review from isra-fel

@VeryEarly VeryEarly Awaiting requested review from VeryEarly

@YanaXu YanaXu Awaiting requested review from YanaXu

@vidai-msft vidai-msft Awaiting requested review from vidai-msft

@notyashhh notyashhh Awaiting requested review from notyashhh

@Pan-Qi Pan-Qi Awaiting requested review from Pan-Qi

+1 more reviewer

@a-santamaria a-santamaria a-santamaria approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NoriZC NoriZC

Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iliu816 @NoriZC @a-santamaria